Re: [GSoC][PATCH 0/2] rebase -i: rewrite append_todo_help() in C

From: Alban Gruin <alban.gruin@gmail.com>
Date: May 31, 2018, 19:25 UTC
Message-ID: <edb744b1-f984-70fc-4639-f0414df8c669@gmail.com>
In-Reply-To: <a6d6e5c1-e7ea-1131-c798-9d5e44603d87@talktalk.net>

Hi Phillip,

Le 31/05/2018 à 19:48, Phillip Wood a écrit :

Show 15 quoted lines

> Hi Alban, it's great to see you working on this
> 
> On 31/05/18 12:01, Alban Gruin wrote:
>> This series rewrites append_todo_help() from shell to C. This is part
>> of the effort to rewrite interactive rebase in C.
>>
>> The first commit rewrites append_todo_help() in C (the C version
>> covers a bit more than the old shell version), adds some parameters to
>> rebase--helper, etc.
> 
> I've had a read of the first patch and I think it looks fine, my only
> comment would be that the help for '--edit-todo' is a bit misleading at
> the moment as currently it's just a flag to tell rebase-helper that the
> todo list is being edited rather than actually implementing the
> functionality to edit the list

Right, what do you think about something like “appends the edit-todo message to the todo list”?

> (but hopefully that will follow in the
> future).
>

This is the next step :)

Cheers, Alban