Re: [GSoC][PATCH v4 1/2] sequencer: make two functions and an enum from sequencer.c public

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 26, 2018, 21:41 UTC
Message-ID: <nycvar.QRO.7.76.6.1806262337360.21419@tvgsbejvaqbjf.bet>
In-Reply-To: <20180626161643.31152-2-alban.gruin@gmail.com>

Hi Alban,

On Tue, 26 Jun 2018, Alban Gruin wrote:

Show 20 quoted lines

> diff --git a/sequencer.h b/sequencer.h
> index c5787c6b5..08397b0d1 100644
> --- a/sequencer.h
> +++ b/sequencer.h
> @@ -3,6 +3,7 @@
>  
>  const char *git_path_commit_editmsg(void);
>  const char *git_path_seq_dir(void);
> +const char *rebase_path_todo(void);
>  
>  #define APPEND_SIGNOFF_DEDUP (1u << 0)
>  
> @@ -57,6 +58,10 @@ struct replay_opts {
>  };
>  #define REPLAY_OPTS_INIT { .action = -1, .current_fixups = STRBUF_INIT }
>  
> +enum check_level {
> +	CHECK_IGNORE = 0, CHECK_WARN, CHECK_ERROR
> +};
> +

While this is contained within scopes that include `sequencer.h`, it *is* public now, so I am slightly uneasy about keeping this enum so generic. Maybe we want to use

enum missing_commit_check_level {
	MISSING_COMMIT_CHECK_IGNORE = 0,
	MISSING_COMMIT_CHECK_WARN,
	MISSING_COMMIT_CHECK_ERROR
};

instead?

Ciao, Dscho