git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ks/precompute-completion

From
Jakub Narebski <jnareb@gmail.com>
Date
Oct 23, 2009, 20:20 UTC
Message-ID
<m3d44deu93.fsf@localhost.localdomain>
In-Reply-To
<7v1vktc1uk.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> Sverre Rabbelier <srabbelier@gmail.com> writes:
> 
> > This is my main concern, adding 'bash_completion' as a target to all:
> > would be ok; why would 'make clean' break it? As long as you don't add
> > "make -C contrib/completion clean' to the main clean target there's no
> > problem?
> 
> "make clean" should remove it, because it is a normal build product,
> if you make your "make all" build completion scripts.
> 
> The word _should_ is used in the RFC2119 sense: there may exist valid
> reasons in particular circumstances to ignore a particular item, but the
> full implications must be understood and carefully weighed before choosing
> a different course.

If we take similar approach to the way gitweb can be build to the bash completion script, which means building it via

  make contrib/completion/git-completion.bash

(and not make this target part of "make all"), then there is, I think, no reason for "make clean" to remove it, isn't it?

-- 
Jakub Narebski
Poland
ShadeHawk on #git
Previous: Sverre RabbelierNext: Sverre Rabbelier
Message 30 of 33 in “What's cooking in git.git (Oct 2009, #04; Wed, 21)”
  1. Junio C HamanoOct 22, 2009
  2. ks/precompute-completion (was Re: What's cooking in git.git (Oct 2009, #04; Wed, 21))Stephen Boyd, Oct 22, 2009
  3. Sverre RabbelierOct 22, 2009
  4. Stephen BoydOct 22, 2009
  5. A Large Angry SCMOct 22, 2009
  6. Johannes SchindelinOct 22, 2009
  7. Jakub NarebskiOct 22, 2009
  8. Nguyen Thai Ngoc DuyOct 22, 2009
  9. skillzero@gmail.comOct 22, 2009
  10. Junio C HamanoOct 22, 2009
  11. Stephen BoydOct 22, 2009
  12. Junio C HamanoOct 24, 2009
  13. add tests for git diff --submoduleJens Lehmann, Oct 23, 2009
  14. Junio C HamanoOct 24, 2009
  15. Clemens BuchacherOct 25, 2009
  16. Junio C HamanoOct 26, 2009
  17. Clemens BuchacherOct 26, 2009
  18. Stephen BoydOct 26, 2009
  19. Clemens BuchacherOct 26, 2009
  20. Shawn O. PearceOct 27, 2009
  21. Junio C HamanoOct 28, 2009
  22. Shawn O. PearceOct 27, 2009
  23. Shawn O. PearceOct 28, 2009
  24. A Large Angry SCMOct 22, 2009
  25. Sverre RabbelierOct 23, 2009
  26. Junio C HamanoOct 23, 2009
  27. Sverre RabbelierOct 23, 2009
  28. Junio C HamanoOct 23, 2009
  29. Sverre RabbelierOct 23, 2009
  30. Jakub NarebskiOct 23, 2009
  31. Sverre RabbelierOct 23, 2009
  32. A Large Angry SCMOct 23, 2009
  33. Sverre RabbelierOct 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.