ks/precompute-completion (was Re: What's cooking in git.git (Oct 2009, #04; Wed, 21))

From: Stephen Boyd <bebarino@gmail.com>
Date: Oct 22, 2009, 08:34 UTC
Message-ID: <4AE0190E.8020803@gmail.com>
In-Reply-To: <7veiovly35.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 5 quoted lines

> * ks/precompute-completion (2009-10-05) 1 commit.
>   (merged to 'next' on 2009-10-14 at adf722a)
>  + Speedup bash completion loading
>
> Are people happy with this?

No. I now have rebase.sh, am.sh, etc. in my completion because of how git help -a fully lists git commands in libexec and elsewhere in my $PATH (which gets pointed to my build directory during make).

It's late and I'm tired, but I think we can just ignore files ending in *.sh, *.perl, etc.

diff --git a/contrib/completion/git-completion.bash.generate b/contrib/completion/git-completion.bash.generate
index 33b1d1d..6487fd5 100755
--- a/contrib/completion/git-completion.bash.generate
+++ b/contrib/completion/git-completion.bash.generate
@@ -24,6 +24,7 @@ __git_all_commands ()
        do
                case $i in
                *--*)             : helper pattern;;
+               *.sh|*.perl)      : build scripts;;
                *) echo $i;;
                esac
        done