Re: ks/precompute-completion

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 23, 2009, 18:59 UTC
Message-ID: <7vd44eaqc5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <fabb9a1e0910231127i3ab469qebdc17168a58f22a@mail.gmail.com>

Sverre Rabbelier <srabbelier@gmail.com> writes:

Show 6 quoted lines

> Ah, no, I meant that as part of my semi-regular git update (during
> which I do 'make && make install') I want to have up-to-date bash
> completion, preferably installed somewhere system-wide; currently I am
> forced to have a 'source
> /home/sverre/code/git/contrib/completion/git-completion.bash' in my
> .bashrc,..

If you have enough privilege to run 'make && make install' regularly into a system-wide place, I presume you can have a system-wide rc that sources /home/sverre/code/git/contrib/completion/git-completion.bash, no?

I think there are two issues.

 1. The series will break your rc script (either $HOME/.bashrc, or
    system-side) that sources $git/contrib/completion/git-completion.bash
    because it has to be built; having "make" generate it may alleviate
    the issue, but "make clean" will break it again, so it is not
    something you can solve in any way other than changing your setting.

 2. Some people have been expecting "make install" not to install the bash
    completion anywhere.

So perhaps "make && make install-contrib"?