Re: What's cooking in git.git (Oct 2009, #04; Wed, 21)
- From
Clemens Buchacher <drizzd@aon.at>
- Date
- Oct 26, 2009, 10:07 UTC
- Message-ID
- <20091026100756.GA9874@localhost>
- In-Reply-To
- <4AE56552.70407@gmail.com>
On Mon, Oct 26, 2009 at 02:01:06AM -0700, Stephen Boyd wrote:
Show 9 quoted lines
> Clemens Buchacher wrote: > > > Why does your PATH include the build directory during make, Stephen? > > The Makefile says: > > git-completion.bash: git-completion.bash.in git-completion.bash.generate > # Generate completions for binaries we have just built > PATH="$(shell pwd)/../..:$$PATH" ./git-completion.bash.generate
Right, of course. I guess ignoring *.sh and *.perl is reasonable then.
> Personally, I'd rather keep it dynamic but I can see how it's useful to > get the 10x speedup. It would be really cool if we could have the best > of both worlds, where I keep my dynamic loading, but others can build > the completion and get the speedup.
Should not be too hard to do using a configuration variable like core.completion = dynamic.
Clemens