Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.)

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Feb 9, 2009, 21:03 UTC
Message-ID: <kCHkjagMqmrTXbd229odxLGt0neIkfVZDCJPnhpXGVU71q9GcXEmPw@cipher.nrlssc.navy.mil>
In-Reply-To: <49908B1A.7040101@beonex.com>

Ben Bucksch wrote:

Show 9 quoted lines

> On 09.02.2009 20:51, Ben Bucksch wrote:
>> On 09.02.2009 20:30, Brandon Casey wrote:
>>> Did you try it with the message I sent titled
>>> '[PATCH] example patch corrupted by thunderbird'?
>>
>> I tried now, and none of the editors/viewers I tried are displaying
>> anything that would come close to readable to me, even if you count
>> clearly marked hex character codes as readable. I tried less, e3 and
>> kwrite. Therefore, a) I can't verify whether the result is correct or not

You could look to see whether there are 6 lines in the hunk or 7. There should only be 6.

  i.e. something like:

  @@ -0,0 +1,6 @@
  +T31,23
  +m4_location(_AC_LIST_MEMBER_IF)autoconf/fortran.m4:115
  +T17,203
  +m4_cr_not_Letters<sequence_of_control_characters>
  +<more_control_characters>
  +T15,855
  --

I have attached the original patch. The headers will be different, and in the attached patch they are only placeholders, but the content after the '---' should be identical in all versions.

> I now compared the result of File | Save as.... (main menu, not context
> menu)

main menu or context menu both produce the same results for me. Do they produce different results for you?

> | "1.eml" with the email on the cyrus server, and they are
> identical (diff and md5sum). So, TB *does* save it correctly,
> byte-for-byte.

Sorry, but I think you did your comparison wrong. Possibly the tool which extracted the email from the cyrus server performed the same transformation that Thunderbird does.

You can also make a comparison with what is saved when you do 'View | Message Source' which pops up a new window, and then File | Save Page As...

For me, they produce two different results. The one produced by 'View | Message Source ..etc' has a message body which is identical to the one saved by pine, and to the original which is attached.

-brandon

From 9ad60e2f109029f8c96fcdc111625017cb8f3ef2 Mon Sep 17 00:00:00 2001
From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Wed, 14 Jan 2009 07:24:52 -0600
Subject: [PATCH] example patch corrupted by thunderbird

This is an example patch which is corrupted when saved using Thunderbird v2.0.0.19.

---

diff --git a/autoconf.m4f b/autoconf.m4f
new file mode 100644
index 0000000..73283b5
--- /dev/null
+++ b/autoconf.m4f
@@ -0,0 +1,6 @@
+T31,23
+m4_location(_AC_LIST_MEMBER_IF)autoconf/fortran.m4:115
+T17,203
+m4_cr_not_Letters	
+
 !"#$%&'()*+,./0123456789:;<=>?@[\]^_`{|}~��������������������������������������������������������������������������������������������������������������������������������-
+T15,855

-- 
1.6.1.239.gcf3bf