Re: [PATCH v2] Enable setting attach as the default in .gitconfig for git-format-patch.

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2009, 01:41 UTC
Message-ID: <7v3aenrrtx.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <498E50E2.8050309@codeweavers.com>

Jeremy White <jwhite@codeweavers.com> writes:

Show 20 quoted lines

> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
> index 11a7d77..2e8e94e 100644
> --- a/Documentation/git-format-patch.txt
> +++ b/Documentation/git-format-patch.txt
> @@ -174,7 +174,8 @@ CONFIGURATION
>  -------------
>  You can specify extra mail header lines to be added to each message
>  in the repository configuration, new defaults for the subject prefix
> -and file suffix, and number patches when outputting more than one.
> +and file suffix, control attachements, and number patches when outputting
> +more than one.
>  
>  ------------
>  [format]
> @@ -183,6 +184,7 @@ and file suffix, and number patches when outputting more than one.
>  	suffix = .txt
>  	numbered = auto
>  	cc = <email>
> +	attach [ = mime-boundary-string ]
>  ------------

Once you added this configuration, if you ever wanted to defeat it for a single invocation, how would you do so? Edit the configuration file again?

Not that I am objecting to the patch, as I am unlikely to have such a configuration, but are there people who need to send attachment sometimes but not other times? They can say --attach from the command line without adding the configuraiton if they send their patch non-attached more often than as an attachment, but if they most of the time need to attach but sometimes need to send in-line, they do not have an easy way to do so.