Re: [PATCH v3 4/7] t2402: ensure locked worktree is properly cleaned up
- From
Rafael Silva <rafaeloliveira.cs@gmail.com>
- Date
- Jan 24, 2021, 10:19 UTC
- Message-ID
- <gohp6klfciocwj.fsf@gmail.com>
- In-Reply-To
- <CAPig+cQobybm7mddLws5v3F9A+uy2b5gV=UB10KG=iQAhFcBAA@mail.gmail.com>
Eric Sunshine writes:
Show 19 quoted lines
> On Tue, Jan 19, 2021 at 4:28 PM Rafael Silva > <rafaeloliveira.cs@gmail.com> wrote: >> In c57b3367be (worktree: teach `list` to annotate locked worktree, >> 2020-10-11) introduced a new test to ensure locked worktrees are listed >> with "locked" annotation. However, the test does not clean up after >> itself as "git worktree prune" is not going to remove the locked worktree >> in the first place. This not only leaves the test in an unclean state it >> also potentially breaks following tests that relies on the >> "git worktree list" output. > > A couple grammos: > > 1) Drop "In" from the start of the first sentence. > 2) s/relies/rely/ > > But please do not re-roll just for this. It's good enough as-is. > > The patch itself is fine. >
Nice catch. I'll be re-rolling the series with the documentation addition suggested by Phillip and the test fixes suggested by you. So, I'll include these changes as well.
-- Thanks Rafael