Re: [PATCH 0/7] teach `worktree list` verbose mode and prunable annotations
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 8, 2021, 08:19 UTC
- Message-ID
- <CAPig+cQSvX2EEGa5h8=kJJkNr2buBiDObN948nx_LaMT4jn3tg@mail.gmail.com>
- In-Reply-To
- <gohp6kpn2gsepd.fsf@gmail.com>
On Fri, Jan 8, 2021 at 2:38 AM Rafael Silva <rafaeloliveira.cs@gmail.com> wrote:
Show 14 quoted lines
> Eric Sunshine writes: > > On Mon, Jan 4, 2021 at 11:22 AM Rafael Silva > > <rafaeloliveira.cs@gmail.com> wrote: > >> The fifth patch adds worktree_escape_reason() that accepts a (char *) > >> text and returned the text with any LF or CRLF escaped. [...] > > > > Perhaps I misunderstand, but I had envisioned employing one of the > > codebase's existing quoting/escaping functions rather than crafting a > > new one from scratch. However, I'll reserve judgment until I actually > > read the patch. > > Agreed. It make sense to reuse one of the already implemented functions > from the code base. for some reason I was not able to find it. I believe > this was cleared out in one of the patches replies by you and Phillip Wood.
No need to apologize. It's a big project and it can be difficult to discover existing utility functions. Fortunately, reviewers can often point out useful alternatives.