Re: [PATCH v3 4/7] t2402: ensure locked worktree is properly cleaned up

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 24, 2021, 07:50 UTC
Message-ID: <CAPig+cQobybm7mddLws5v3F9A+uy2b5gV=UB10KG=iQAhFcBAA@mail.gmail.com>
In-Reply-To: <20210119212739.77882-5-rafaeloliveira.cs@gmail.com>

On Tue, Jan 19, 2021 at 4:28 PM Rafael Silva <rafaeloliveira.cs@gmail.com> wrote:

Show 7 quoted lines

> In c57b3367be (worktree: teach `list` to annotate locked worktree,
> 2020-10-11) introduced a new test to ensure locked worktrees are listed
> with "locked" annotation. However, the test does not clean up after
> itself as "git worktree prune" is not going to remove the locked worktree
> in the first place. This not only leaves the test in an unclean state it
> also potentially breaks following tests that relies on the
> "git worktree list" output.

A couple grammos:

1) Drop "In" from the start of the first sentence.
2) s/relies/rely/

But please do not re-roll just for this. It's good enough as-is.

The patch itself is fine.

> Let's fix that by unlocking the worktree before the "prune" command.
>
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Rafael Silva <rafaeloliveira.cs@gmail.com>