Re: [PATCH v3 0/7] teach `worktree list` verbose mode and prunable annotations

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 30, 2021, 07:04 UTC
Message-ID: <CAPig+cTt-TyOR8kc6YvBVLpf-bgFdJ+FVYA2NvG_Vvn7tMbBkQ@mail.gmail.com>
In-Reply-To: <20210127080310.89639-1-rafaeloliveira.cs@gmail.com>

On Wed, Jan 27, 2021 at 3:03 AM Rafael Silva <rafaeloliveira.cs@gmail.com> wrote:

Show 7 quoted lines

> Changes in v4
>  * Added documentation to explain that the lock reason is quoted with
>    the same rules as described for `core.quotePath`.
>  * The `worktree unlock` issued in the test cleanup is splitted and
>    executed after each `worktree lock` to ensure the unlock is only
>    done after we know each locked command was successful.
>  * Fix a couple of grammos in the [4/7] commit message.

I just gave v4 a complete read-through and it looks great. All review comments on previous rounds have been addressed, and I didn't find anything important to comment on in v4. Very nicely done.

Please consider this entire series:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>

Junio: Perhaps the summary of this series in the merge message can be
refined a bit, as it only talks about verbose mode, but this series
does a bit more than that. Heres a proposal:

    `git worktree list` now annotates worktrees as prunable, shows
    locked and prunable attributes in --porcelain mode, and gained
    a --verbose option.