Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR
On Nov 28, 2007 8:57 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 21 quoted lines
>
> It might be POSIX, but there are shells that do not like the
> expression 'export VAR=VAL'. To be on the safe side, rewrite them
> into 'VAR=VAL' and 'export VAR'.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
> On Wed, 28 Nov 2007, Wincent Colaiuta wrote:
>
> > I'm still a little concerned that nobody commented when I
> > pointed out that export VAR=VAL is used elsewhere in Git,
> > especially in git-clone.sh, which is very commonly-used
> > porcelain. Is it a problem?
>
> How's that for a comment?
>
> git-clone.sh | 2 +-
> git-filter-branch.sh | 20 ++++++++++++--------
> git-quiltimport.sh | 10 ++++++----
> 3 files changed, 19 insertions(+), 13 deletions(-)
Why leave test scripts behind?
--
Duy