Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 28, 2007, 14:27 UTC
Message-ID: <Pine.LNX.4.64.0711281426370.27959@racer.site>
In-Reply-To: <fcaeb9bf0711280619j3479ea6csa74f4b0d907f2a65@mail.gmail.com>

Hi,

On Wed, 28 Nov 2007, Nguyen Thai Ngoc Duy wrote:

Show 24 quoted lines

> On Nov 28, 2007 8:57 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> >
> > It might be POSIX, but there are shells that do not like the
> > expression 'export VAR=VAL'.  To be on the safe side, rewrite them
> > into 'VAR=VAL' and 'export VAR'.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >
> >         On Wed, 28 Nov 2007, Wincent Colaiuta wrote:
> >
> >         > I'm still a little concerned that nobody commented when I
> >         > pointed out that export VAR=VAL is used elsewhere in Git,
> >         > especially in git-clone.sh, which is very commonly-used
> >         > porcelain. Is it a problem?
> >
> >         How's that for a comment?
> >
> >  git-clone.sh         |    2 +-
> >  git-filter-branch.sh |   20 ++++++++++++--------
> >  git-quiltimport.sh   |   10 ++++++----
> >  3 files changed, 19 insertions(+), 13 deletions(-)
> 
> Why leave test scripts behind?

Because I did a

	git grep 'export.*=' *.sh

instead of a

	git grep 'export.*=' -- \*.sh

But this patch is

- good of its own, and

- a comment ;-)

Ciao, Dscho