Re: [PATCH v2] Replace instances of export VAR=VAL with VAR=VAL; export VAR

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 28, 2007, 23:05 UTC
Message-ID: <Pine.LNX.4.64.0711282304360.27959@racer.site>
In-Reply-To: <7vzlwy2dkm.fsf@gitster.siamese.dyndns.org>

Hi,

On Wed, 28 Nov 2007, Junio C Hamano wrote:

Show 10 quoted lines

> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >
> >> It might be POSIX, but there are shells that do not like the
> >> expression 'export VAR=VAL'.
> >
> > As long as we have no positive report about any such shell that
> > _otherwise_ would be usable for git, why bother?
> 
> I thought somebody already mention that ash mishandles "export VAR=VAL"
> but otherwise Ok.

I thought I read an implicit request from you. And yes, there was an incidental bugfix in quiltimport.

Besides, this "why bother?" sounds awfully like "it's in POSIX and I ignore the experience of Junio who knows that there are/were reasons not to use export VAR=VAL" to me. After all, I read this often enough on this list, and just forgot to fix it in filter-branch before submitting the patch.

Ciao, Dscho