Re: Rebase/cherry-picking idea
- From
Wincent Colaiuta <win@wincent.com>
- Date
- Nov 28, 2007, 08:52 UTC
- Message-ID
- <50645A3B-C5F0-4A99-A2B8-AD9251024244@wincent.com>
- In-Reply-To
- <7vir3m94ku.fsf@gitster.siamese.dyndns.org>
El 28/11/2007, a las 9:06, Junio C Hamano escribió:
Show 10 quoted lines
>> Once I get a clear idea of what kind of change is likely to actually >> get accepted I'll submit a proper patch. > > Too often, people disappear with a patch that is basically good but > has > room for improvements this way. I really do not have time nor > bandwidth > to keep bugging them for updates, and often end up cleaning up on my > own > instead.
The problem in this case was that my patch didn't receive any meaningful feedback (ie. suggestions for improvement), only a lot of bikeshed stuff about whether the environment variable should have an underscore prefix or not, whether or not I should use "export FOO=..." or not etc. So I didn't know what was necessary in order to get it accepted.
> This is such a patch, and without acks or comments, it is also very > likely to be lost.
Ok, please disregard the resend that I just posted a few minutes ago (hadn't seen your new patch yet).
Cheers, Wincent