Re: [PATCH 3/3] completion: fix bugs with slashes in remote names

From: phillip.wood123@gmail.com <phillip.wood123@gmail.com>
Date: Mar 7, 2025, 10:34 UTC
Message-ID: <f68f4c5f-1bbc-4c4a-95c1-63799af6991d@gmail.com>
In-Reply-To: <CALnO6CBDjQgc2TNaXbBWiUNqWV=RgrL2Ry-7HzRu3Ozuqazzvw@mail.gmail.com>

Hi Ben

On 06/03/2025 20:24, D. Ben Knoble wrote:

> On Mon, Mar 3, 2025 at 2:25 PM David Mandelberg <david@mandelberg.org> wrote:
>> Op 2025-03-03 om 11:36 schreef phillip.wood123@gmail.com:

>>

Show 13 quoted lines

>>> Thanks, I'm not familiar with bash's extensions to parameter
>>> substitution. The completions can also but used under zsh (git-
>>> completion.zsh is pretty much abandoned I think) but it looks like bash
>>> and zsh agree on this expansion.
> 
> I don't think "abandoned" is the right characterization—at least, it's
> the completion script that Homebrew-installed Git users will get for
> Zsh, and it does re-use the Bash completion scripts (which therefore
> ought to stay portable between both if possible, otherwise we get
> stuff like 8776470cf3 (completion: repair config completion for Zsh,
> 2025-01-06)). The Zsh script has seen some fixups over time (such as
> my own 3c20acdf46 (completion: zsh: stop leaking local cache variable,
> 2024-04-30)).

Thanks for clarifying that, I'd misunderstood the relationship between git-completion.zsh and git-completion.bash.

Best Wishes

Phillip