Re: [PATCH 3/3] completion: fix bugs with slashes in remote names

From: David Mandelberg <david@mandelberg.org>
Date: Mar 7, 2025, 20:11 UTC
Message-ID: <05bf397e-4bc2-4255-87b5-925c80667f4c@mandelberg.org>
In-Reply-To: <xmqqh645hopj.fsf@gitster.g>

Op 2025-03-06 om 15:46 schreef Junio C Hamano:

> Apparently I am late to the party, but I have to wonder how
> prevalent it is to use such a name for remotes.

 From a quick search, it looks like I'm not the only one, but I don't 
know how common it is: https://github.com/desktop/desktop/issues/3618

I'm not sure if I'm remembering right, but I think I got the idea from seeing slashes in branch names to organize a hierarchy of branches, and realizing I could do the same with remotes. Was it intentional to allow slash in branch names, or is that a similar situation?

> As a remote name, we still do use "is that a
> file on the filesystem?" to see if it is a local file:// URL
> (i.e. "git fetch github/dseomn" may be fetching from a subdirectory
> two levels down);

That's a good reason not to use slashes in remotes that I didn't know about, thanks!

> Anyway, this is not something we'd do lightly, but we may want to
> see if we should tighten the naming rules for remote nicknames and
> the mapping from nicknames to remote-tracking hiearchy, at Git 3.0
> version boundary.

What does that mean for this patch now? Do you want to fix the completion for the currently (unintentionally) supported remote names, or leave it broken to discourage their use? Fixing the completion might also give anybody reading the completion script the idea that slashes in remote names are somewhat sanctioned.