From: phillip.wood123@gmail.com Date: Fri, 07 Mar 2025 10:34:45 GMT Subject: Re: [PATCH 3/3] completion: fix bugs with slashes in remote names Message-ID: In-Reply-To: Hi Ben On 06/03/2025 20:24, D. Ben Knoble wrote: > On Mon, Mar 3, 2025 at 2:25 PM David Mandelberg wrote: >> Op 2025-03-03 om 11:36 schreef phillip.wood123@gmail.com: >> >>> Thanks, I'm not familiar with bash's extensions to parameter >>> substitution. The completions can also but used under zsh (git- >>> completion.zsh is pretty much abandoned I think) but it looks like bash >>> and zsh agree on this expansion. > > I don't think "abandoned" is the right characterization—at least, it's > the completion script that Homebrew-installed Git users will get for > Zsh, and it does re-use the Bash completion scripts (which therefore > ought to stay portable between both if possible, otherwise we get > stuff like 8776470cf3 (completion: repair config completion for Zsh, > 2025-01-06)). The Zsh script has seen some fixups over time (such as > my own 3c20acdf46 (completion: zsh: stop leaking local cache variable, > 2024-04-30)). Thanks for clarifying that, I'd misunderstood the relationship between git-completion.zsh and git-completion.bash. Best Wishes Phillip