Re: [PATCH v3 2/2] completion: fix bugs with slashes in remote names

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Mar 18, 2025, 17:02 UTC
Message-ID: <d6945541-c106-49a2-8072-2a4e1b8903eb@gmail.com>
In-Reply-To: <xmqq34ffdwnl.fsf@gitster.g>

On 14/03/2025 23:23, Junio C Hamano wrote:

Show 7 quoted lines

> 
> Entirely up to you.  I do not plan to perform an in-detail review on
> the topic (I do not consider myself quite qualified), but others who
> saw earlier rounds of the patch may want to say "now this is perfect"
> or "now this is perfect with this and that changes", and if you do not
> think the differenes between v3 and your upcoming v4 are small enough,
> it may be more efficient to wait for a bit to collect more comments.

I'm not an expert on our completion script but from a general shell scripting perspective this version looks fine to me.

Best Wishes

Phillip

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.