Re: [PATCH v3 2/2] completion: fix bugs with slashes in remote names
- From
David Mandelberg <david@mandelberg.org>
- Date
- Mar 14, 2025, 22:37 UTC
- Message-ID
- <015b89f8-63eb-4203-8d43-47c9a6d65cda@mandelberg.org>
- In-Reply-To
- <xmqqo6y3dzno.fsf@gitster.g>
Op 2025-03-14 om 18:18 schreef Junio C Hamano:
Show 11 quoted lines
> David Mandelberg <david@mandelberg.org> writes: > >> + __git for-each-ref --format='%(refname)' 'refs/remotes/**' | > > Just a bit of curiosity, but how would this be different from using > > __git for-each-ref --format='%(refname)' refs/remotes/ > > i.e. the prefix match, here? Does the wildmatcher clever enough to > optimize "**" away and make it just to iterate over refs/remotes/ > hierarchy without filtering anything?
Oh right, I lost track of that bit. When I wrote that, I didn't know that for-each-ref did prefix matching. Phillip Wood pointed it out:
> If there are no glob characters then "git for-each-ref" does a prefix match so strictly speaking you don't need the '**' but I don't think it matters in practice.
But I forgot about it when I sent v3.
Do you want me to change it? Should I send a v4 now, or just make a fixup commit locally so I don't forget it when I send a v4 in the future?