[PATCH v6 6/6] config: make git_configset_get_string_tmp() private
- From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Feb 7, 2022, 21:33 UTC
- Message-ID
- <f687a0bfa167aa453a531ad4d2ec9687887a90e7.1644269584.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1101.v6.git.1644269583.gitgitgadget@gmail.com>
From: Derrick Stolee <dstolee@microsoft.com>
This method was created in f1de981e8 (config: fix leaks from git_config_get_string_const(), 2020-08-14) but its only use was in the repo_config_get_string_tmp() method, also declared in config.h and implemented in config.c. Since this is otherwise unused and is a very similar implementation to git_configset_get_value(), let's remove this declaration.
Signed-off-by: Derrick Stolee <dstolee@microsoft.com> --- config.c | 4 ++-- config.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/config.c b/config.c index 1a03ced1a54..870b22dd2ff 100644 --- a/config.c +++ b/config.c @@ -2179,8 +2179,8 @@ int git_configset_get_string(struct config_set *cs, const char *key, char **dest return 1; } -int git_configset_get_string_tmp(struct config_set *cs, const char *key, - const char **dest) +static int git_configset_get_string_tmp(struct config_set *cs, const char *key, + const char **dest) { const char *value; if (!git_configset_get_value(cs, key, &value)) { diff --git a/config.h b/config.h index 1d98ad269bd..184aef1eca4 100644 --- a/config.h +++ b/config.h @@ -494,7 +494,6 @@ void git_configset_clear(struct config_set *cs); int git_configset_get_value(struct config_set *cs, const char *key, const char **dest); int git_configset_get_string(struct config_set *cs, const char *key, char **dest); -int git_configset_get_string_tmp(struct config_set *cs, const char *key, const char **dest); int git_configset_get_int(struct config_set *cs, const char *key, int *dest); int git_configset_get_ulong(struct config_set *cs, const char *key, unsigned long *dest); int git_configset_get_bool(struct config_set *cs, const char *key, int *dest);
-- gitgitgadget