Re: [PATCH v6 0/6] Sparse checkout: fix bug with worktree of bare repo

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 8, 2022, 05:02 UTC
Message-ID: <CAPig+cT7GwyhPOBdqDDh8jGm+mWK1x9Gt4Zebcw34dgFyaufkw@mail.gmail.com>
In-Reply-To: <CABPp-BG4m6i+yobjnD6UC5S5n3k-HbB7Y5uUNEvrD79ErOoYHg@mail.gmail.com>

On Mon, Feb 7, 2022 at 11:14 PM Elijah Newren <newren@gmail.com> wrote:

Show 7 quoted lines

> On Mon, Feb 7, 2022 at 1:33 PM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > Updates in v6
> >  * Updated documentation to use "working tree" over "worktree" and "" over
> >    ""
>
> Not sure what "" over "" means.

Probably related to my review comment[1] about spelling it "$GIT_DIR/worktrees/<id>/" rather than "$GIT_DIR/worktrees/<worktree-name>/".

Show 5 quoted lines

> >  * Delay some allocations to avoid leaking memory in error conditions.
> >  * Use "main worktree" over "base worktree" in comments.
> >  *
>
> Was the empty bullet point meant to cover the new patch 6?

The "Updates in v6" section was botched a bit. If you look closely, the remaining bullet points actually ended up in the "Updates in v5" section. The complete "Updates in v6" section should have been (approximately):

 * Updated documentation to use "working tree" over "worktree" and
   "<id>" over "<worktree-name>"
 * Delay some allocations to avoid leaking memory in error conditions.
 * Use "main worktree" over "base worktree" in comments.
 * Removed use of git_configset_get_string_tmp() and added a patch that
   removes its public declaration.
 * Fragile variables are replaced with better ones.
 * Variable names and code style improved.
 * Several test cleanups in patch 5.

[1]: https://lore.kernel.org/git/pull.1101.v4.git.1643136134.gitgitgadget@gmail.com/T/#m4926177771017bbea82c33e9e03e6a9a004ebf24