Re: [PATCH v5 5/5] worktree: copy sparse-checkout patterns and config on add

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 15, 2022, 22:01 UTC
Message-ID: <CAPig+cS6Of=1OOw-6MOCBJVW6_FxtGw_ciUR=RTYakdy=1Z_hA@mail.gmail.com>
In-Reply-To: <93747eca-08d6-0be9-08c7-42c81340b788@gmail.com>

On Mon, Feb 7, 2022 at 9:30 AM Derrick Stolee <stolee@gmail.com> wrote:

Show 10 quoted lines

> On 2/6/2022 6:30 AM, Eric Sunshine wrote:
> > On Mon, Jan 31, 2022 at 10:01 AM Derrick Stolee via GitGitGadget
> > <gitgitgadget@gmail.com> wrote:
> >> +               git config --worktree bogus.key value &&
> >> +               git config --unset core.bare &&
> >
> > Why is this being unset? (Genuine question. Am I missing something obvious?)
>
> I'm moving it out of the common config file. Earlier commands
> enabled it in the config.worktree file for this working tree.

But won't the `git worktree add` commands which immediately follow this bit automatically drop `core.bare=true` from the common config file? Or am I misthinking on this? Or are you just trying to be explicit here with the manual removal?