Re: [PATCH v3 4/4] add-patch: render hunks through the pager

From: phillip.wood123@gmail.com <phillip.wood123@gmail.com>
Date: Jul 18, 2024, 09:58 UTC
Message-ID: <f52d5c9c-e96c-430f-a49a-eb2ee6e19d9f@gmail.com>
In-Reply-To: <2b57479c-29c8-4a6e-b7b0-1309395cfbd9@gmail.com>

Hi Rubén

On 17/07/2024 18:20, Rubén Justo wrote:

> However, this error has exposed a problem: calling `wait_for_pager` if
> `setup_pager` hasn't worked is an issue that needs to be addressed in this
> series: `setup_pager` should return a result.

It already dies if we cannot execute the pager so maybe we should just die on other errors as well?

Best Wishes

Phillip

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.