Re: Re* [PATCH v3 4/4] add-patch: render hunks through the pager

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 23, 2024, 02:31 UTC
Message-ID: <xmqq4j8g6dqv.fsf@gitster.g>
In-Reply-To: <CAO_smVhd4LY_F0Wgt1CfsidFAB1n_8Rv3sXaBCgrCuOVMxS5cw@mail.gmail.com>

Kyle Lippincott <spectral@google.com> writes:

Show 6 quoted lines

> I was also able to reproduce both aspects of this behavior (doesn't
> export, value is retained) with ksh (sh (AT&T Research) 93u+m/1.0.8
> 2024-01-01), which is the current version on debian testing. So maybe
> "some versions of ksh (tested: 93u+m/1.0.8 2024-01-01) and dash
> (0.5.10.2-6)"? Or maybe we move the 'some versions' around, because I
> think it's probably all versions of ksh :)

Makes sense, but I think "POSIX guarantees that the behaviour is something you should not rely on by telling us that these are unspecified", which you found, is a much better rationale to explicitly forbid "VAR=VAL shell_func" construct.

Besides, as another thread recently discussed, our test scripts, with really heavy uses of "local", do not work at all with AT&T ksh (other ksh clones are reported to be OK, though). So it may be OK to write it off as "unusuable to run our tests", at least for now.