Re: [PATCH v3 4/4] add-patch: render hunks through the pager

From: Rubén Justo <rjusto@gmail.com>
Date: Jul 20, 2024, 22:45 UTC
Message-ID: <ba1c3bca-177c-4dae-b4c3-1a4deab27d5e@gmail.com>
In-Reply-To: <f52d5c9c-e96c-430f-a49a-eb2ee6e19d9f@gmail.com>

On Thu, Jul 18, 2024 at 10:58:36AM +0100, phillip.wood123@gmail.com wrote:

Show 6 quoted lines

> > However, this error has exposed a problem: calling `wait_for_pager` if
> > `setup_pager` hasn't worked is an issue that needs to be addressed in this
> > series: `setup_pager` should return a result.
> 
> It already dies if we cannot execute the pager so maybe we should just die
> on other errors as well?

Honestly, I thought 78f0a5d187 (pager: die when paging to non-existing command, 2024-06-23) would be sufficient for this series, but I missed the optimization mentioned in my previous message.

Thinking in the context of "add -p", it might be more sensible not to die but simply show an error, so as not to end the user's interactive session. But it could be a change in a future series and thus avoid prolonging this one.

However, if you can think of any other cases where we should be stricter and die, I'm all ears.