Re: [PATCH v2 0/4] use the pager in 'add -p'

From: Rubén Justo <rjusto@gmail.com>
Date: Jul 13, 2024, 23:21 UTC
Message-ID: <ec13ed8a-3ad8-45d0-9120-2f5ddabc14fc@gmail.com>
In-Reply-To: <xmqq7cdpb4op.fsf@gitster.g>

On Sat, Jul 13, 2024 at 10:08:22AM -0700, Junio C Hamano wrote:

Show 17 quoted lines

> Rubén Justo <rjusto@gmail.com> writes:
> 
> >     -+	test_write_lines P |
> >     -+	(
> >     -+		GIT_PAGER="head -1" &&
> >     -+		export GIT_PAGER &&
> >     -+		test_terminal git add -p >actual
> >     -+	) &&
> >     -+	tail -n 7 <actual | test_decode_color >actual.trimmed &&
> >     -+	test_cmp expect actual.trimmed
> >     ++	test_write_lines P q | GIT_PAGER="head -c 1" test_terminal git add -p >actual
> >      +'
> 
> "make test" has this to say:
> 
> t3701-add-interactive.sh:619: error: head -c is not portable (use test_copy_bytes BYTES <file >out): test_write_lines P q | GIT_PAGER="head -c 1" test_terminal git add -p >actual
> gmake[1]: *** [Makefile:132: test-lint-shell-syntax] Error 1

Ouch. I'll fix it. I think I'll go back to "head -1". But I'll wait to hear comments about the change in the message.