From: phillip.wood123@gmail.com Date: Thu, 18 Jul 2024 09:58:36 GMT Subject: Re: [PATCH v3 4/4] add-patch: render hunks through the pager Message-ID: In-Reply-To: <2b57479c-29c8-4a6e-b7b0-1309395cfbd9@gmail.com> Hi Rubén On 17/07/2024 18:20, Rubén Justo wrote: > However, this error has exposed a problem: calling `wait_for_pager` if > `setup_pager` hasn't worked is an issue that needs to be addressed in this > series: `setup_pager` should return a result. It already dies if we cannot execute the pager so maybe we should just die on other errors as well? Best Wishes Phillip