Re: What's in git.git (stable)
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Dec 15, 2006, 14:39 UTC
- Message-ID
- <elubv2$6ag$1@sea.gmane.org>
- In-Reply-To
- <45810B49.2000706@op5.se>
Andreas Ericsson wrote:
Show 18 quoted lines
> Junio C Hamano wrote: >> Andy Parkins <andyparkins@gmail.com> writes: >> >>> * git-add has no output, whether it works or not >> >> "git add no-such-file" complains, and I think that is adequate. >> Now with Nico's 'add means adding contents, not path' change is >> in, we _might_ want to differentiate adding a path that was >> untracked before and updating the contents, but I think this >> again falls into "doing exactly as told" category. >> > > Well, it should really let the user know if it fails. I for one would > like to know that. I wasn't aware of the fact that it was silent even in > those situations (perhaps because I've never run across it). > > The errors that need to be reported are, afaics: > Content in 'path/to/file' is ignored according to path/to/.gitignore.
This is not an error, just a warning. Sometimes user want's to add a file which is otherwise ignored (e.g. due to glob), sometimes user adds ignored file by mistake.
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git