Re: [PATCH] make commit message a little more consistent and conforting
- From
Andreas Ericsson <ae@op5.se>
- Date
- Dec 15, 2006, 15:50 UTC
- Message-ID
- <4582C442.5050704@op5.se>
- In-Reply-To
- <20061215154025.GF17860@spearce.org>
Shawn Pearce wrote:
Show 15 quoted lines
> Andreas Ericsson <ae@op5.se> wrote: >> Yes, but it makes sense for merges where you generally pull someone >> elses work or one of your topic branches because it gives a general feel >> for the amount of modifications and are a sort of conclusion. Commits >> are a different thing, because you should know what kind of changes >> you've just done. If you don't you have other problems. I for one run >> git diff quite frequently when I'm getting close to a commit to make >> sure I don't get only the changes I want. I imagine others do too, so >> getting a diffstat when issuing the actual commit would just be noisy >> and irritating. > > I do the same (diff a lot before commit) and thus find commit > outputting anything at all to be noisy and irritating. Frankly > the new >
I could live with one line (Committed revision %d), but a diffstat is always 3 lines minimum, which might well turn out to be 2 lines more than I changed. That's way too noisy.
-- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se