Re: [PATCH/RFC 7/7] t7006-pager: if stdout is not a terminal, make a new one

From: Brandon Casey <drafnel@gmail.com>
Date: Feb 20, 2010, 03:42 UTC
Message-ID: <ee63ef31002191942h7fbbb6bt627cd36ea343e606@mail.gmail.com>
In-Reply-To: <20100220003950.GA18550@progeny.tock>

On Fri, Feb 19, 2010 at 6:39 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 25 quoted lines

> Brandon Casey wrote:
>>>> On Fri, Feb 19, 2010 at 02:19:47AM -0600, Jonathan Nieder wrote:
>
>>>>> Hmm, how about /dev/ptmx?  (One can check by replacing posix_openpt(...)
>>>>> with open("/dev/ptmx", ...) in the test-terminal.c I sent.)
>>
>> Didn't work on Solaris 7.  I applied your series on top of master with the
>> change you described.  Here's the diff:
> [...]
>> Here's the result of the terminal test:
>>
>>   # ./test-terminal sh -c "test -t 1"
>>   # echo $?
>>   1
> [...]
>>
>> And here's the output of t7006-pager:
>> *** t7006-pager.sh ***
>> *   ok 1: set up terminal for tests
>> * no usable terminal, so skipping some tests
>
> Thanks for trying it out.  That’s an excellent outcome: it means that
> test-terminal compiled without trouble with no makefile magic.  It
> does seem strange to me that there was no error message.  Is
> sh -c "test -t 1" false for an ordinary terminal?

No, it is true.  I also substituted /usr/xpg4/bin/sh and got the same result.

-brandon