Re: [PATCH v2 7/7] t7006-pager: if stdout is not a terminal, make a new one

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 20, 2010, 06:53 UTC
Message-ID: <7vaav42ya1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100220052504.GA24697@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> writes:

>  - Create a new pseudo-terminal on the fly and capture its output.
>
> This patch implements the third approach.

Yuck.  You must be having too much fun ;-).

Show 8 quoted lines

> On non-Unixlike and pre-SVR4 systems, this functionality should be
> disabled by passing NO_GRANTPT=YesPlease to the makefile.  I do not
> know whether Cygwin or HP-UX implements the required functions
> appropriately, so to be safe this patch includes that option for them.
>
> On platforms where test-terminal does not work, the test script will
> maintain its old behavior (skipping most of its tests unless
> GIT_TEST_OPTS includes --verbose).

If we are truly serious about doing this, it might be worthwhile to check how expect (http://expect.nist.gov) does this portably.