Re: [PATCH/RFC 7/7] t7006-pager: if stdout is not a terminal, make a new one

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 20, 2010, 00:39 UTC
Message-ID: <20100220003950.GA18550@progeny.tock>
In-Reply-To: <setkR9a6yaRMOU11ekUmlY6ty8nNSPCcidBKotdDxpQsZLCxc54hKw@cipher.nrlssc.navy.mil>

Brandon Casey wrote:

>>> On Fri, Feb 19, 2010 at 02:19:47AM -0600, Jonathan Nieder wrote:

Show 5 quoted lines

>>>> Hmm, how about /dev/ptmx?  (One can check by replacing posix_openpt(...)
>>>> with open("/dev/ptmx", ...) in the test-terminal.c I sent.)
> 
> Didn't work on Solaris 7.  I applied your series on top of master with the
> change you described.  Here's the diff:

[...]

Show 5 quoted lines

> Here's the result of the terminal test:
> 
>   # ./test-terminal sh -c "test -t 1"
>   # echo $?
>   1

[...]

Show 5 quoted lines

>
> And here's the output of t7006-pager:
> *** t7006-pager.sh ***
> *   ok 1: set up terminal for tests
> * no usable terminal, so skipping some tests

Thanks for trying it out. That’s an excellent outcome: it means that test-terminal compiled without trouble with no makefile magic. It does seem strange to me that there was no error message. Is sh -c "test -t 1" false for an ordinary terminal?

Jonathan