Re: [PATCH/RFC 7/7] t7006-pager: if stdout is not a terminal, make a new one

From: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Date: Feb 19, 2010, 16:25 UTC
Message-ID: <28d--OB9y5MtIy1nJel2Km6d5sqJ3yX6fVUhecDU5ehJUYJmZlE0-A@cipher.nrlssc.navy.mil>
In-Reply-To: <20100219083440.GC13691@coredump.intra.peff.net>

Jeff King wrote:

Show 18 quoted lines

> On Fri, Feb 19, 2010 at 02:19:47AM -0600, Jonathan Nieder wrote:
> 
>> Jeff King wrote:
>>
>>> Solaris 8 and 9 seem to be lacking it. Solaris 10 does have it. AIX 5.2
>>> and 6.1 both have it.
>>>
>>> So it would mean some platforms couldn't run all tests. That is probably
>>> good enough, given that most of our terminal-related bugs have not been
>>> platform-specific problems.
>> Hmm, how about /dev/ptmx?  (One can check by replacing posix_openpt(...)
>> with open("/dev/ptmx", ...) in the test-terminal.c I sent.)
> 
> Solaris 8 does have /dev/ptmx. Sorry, I wasn't able to test it, as my
> sol8 box is very vanilla right now, and I can't actually compile git on
> it (it doesn't even have gmake). :)
> 
> Maybe Brandon (cc'd) can try it.

I'm compiling vanilla master now. If that compiles without error, I'll apply Jonathan's series and make the changes to test-terminal.c that he suggested. I have access to Solaris 7, so you can imagine how fast the machine is... and how long the compile will take.

-brandon