Re: [PATCH/RFC 7/7] t7006-pager: if stdout is not a terminal, make a new one
- From
Jeff King <peff@peff.net>
- Date
- Feb 19, 2010, 08:34 UTC
- Message-ID
- <20100219083440.GC13691@coredump.intra.peff.net>
- In-Reply-To
- <20100219081947.GA12975@progeny.tock>
On Fri, Feb 19, 2010 at 02:19:47AM -0600, Jonathan Nieder wrote:
Show 11 quoted lines
> Jeff King wrote:
>
> > Solaris 8 and 9 seem to be lacking it. Solaris 10 does have it. AIX 5.2
> > and 6.1 both have it.
> >
> > So it would mean some platforms couldn't run all tests. That is probably
> > good enough, given that most of our terminal-related bugs have not been
> > platform-specific problems.
>
> Hmm, how about /dev/ptmx? (One can check by replacing posix_openpt(...)
> with open("/dev/ptmx", ...) in the test-terminal.c I sent.)Solaris 8 does have /dev/ptmx. Sorry, I wasn't able to test it, as my sol8 box is very vanilla right now, and I can't actually compile git on it (it doesn't even have gmake). :)
Maybe Brandon (cc'd) can try it.
> No, not opposed. Just lazy and not so interested in working on it. > I do not want to just take the implementation you provided because I > want to test the scripted git commands, too, though I haven’t gotten > around to that.
Ah, right, I forgot about scripts. That makes things a little uglier, but it should theoretically be possible.
-Peff