Re: [PATCH 0/7] gitweb: Trying to improve history view speed

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 9, 2006, 09:24 UTC
Message-ID: <edu180$vvs$1@sea.gmane.org>
In-Reply-To: <7vvenxwglc.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 14 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> Jakub Narebski wrote:
>>
>>> Shortlog:
>>>  [PATCH 1/7] gitweb: Make pickaxe search a feature
>>>  [PATCH 2/7] gitweb: Paginate history output
>>>  [PATCH 3/7] gitweb: Use @hist_opts as git-rev-list parameters
>>>              in git_history
>>>  [PATCH 4/7] gitweb: Add parse_rev_list for later use
>>>  [PATCH 5/7] gitweb: Use parse_rev_list in git_shortlog and git_history
>>>  [PATCH 6/7] gitweb: Assume parsed revision list in git_shortlog_body
>>>              and git_history_body
>>>  [PATCH 7/7] gitweb: Set page to 0 if it is not defined, in git_history

Show 7 quoted lines

> I do not know about 4, 5 and 6.  I didn't look at them at all
> the first time you sent them out, since I got an impression that
> you did not understand how git-rev-list was supposed to work
> when you did them.
> 
> Now Linus explained it to you, I suspect they would probably
> need to be rethought?

Well, first they don't offer that much of speed improvement even for the first page of output. And probably would be slower than current implementation for the next-to-last, or the last page. So yes, patches 4-6 are to be rethought, if not dropped at all.

By the way, what do you all do with the "failed experiments", to have them saved somewhere, but to not make trouble for normal operations?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git