Re: [PATCH 1/7] gitweb: Make pickaxe search a feature
- From
Junio C Hamano <junkio@cox.net>
- Date
- Sep 7, 2006, 09:02 UTC
- Message-ID
- <7vmz9c2goh.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <edoli0$oql$1@sea.gmane.org>
Jakub Narebski <jnareb@gmail.com> writes:
Show 20 quoted lines
> Junio C Hamano wrote:
>
>> Jakub Narebski <jnareb@gmail.com> writes:
>>
>>> As pickaxe search (selected using undocumented 'pickaxe:' operator in
>>> search query) is resource consuming, allow to turn it on/off using
>>> feature meachanism.
>>
>> I do not have a problem against making it configurable.
>>
>>> + 'pickaxe' => {
>>> + 'sub' => \&feature_pickaxe,
>>> + 'override' => 0,
>>> + 'default' => [0]},
>>> );
>>
>> The patch suggests that it is turned off by default right now; I
>> have not checked it myself, but is that the case?
>
> No, it is not. Currently it is turned on, _but_ undocumented.Then it would be nice to make it documented and keep the default perhaps?