Re: [PATCH 8/8] gitweb: Remove --parents from call to git-rev-list in parse_rev_list
- From
Junio C Hamano <junkio@cox.net>
- Date
- Sep 6, 2006, 21:51 UTC
- Message-ID
- <7vy7sw64vp.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <edndud$csb$1@sea.gmane.org>
Jakub Narebski <jnareb@gmail.com> writes:
Show 7 quoted lines
> Linus Torvalds wrote: > >> But I guess for gitweb, you do want to use --full-history in this case ;( > > It is now easy with patch 3/7 "Use @hist_opts as git-rev-list parameters in > git_history" to remove '--full-history' from git-rev-list parameters in > git_history subroutine.
Well, generating not-so-useful output fast is, eh, not-so-useful anyway, so being able to add or not add to the set of options on a whim is not so much of value. The real value lies in deciding if it is needed (and I think --full-history is needed for gitweb) and if so coming up with a way to get the same result with cheaper operations.