Re: [PATCH 1/7] gitweb: Make pickaxe search a feature
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Sep 7, 2006, 09:07 UTC
- Message-ID
- <edong1$sn1$1@sea.gmane.org>
- In-Reply-To
- <7vmz9c2goh.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes: > >> Junio C Hamano wrote:
Show 7 quoted lines
>>> The patch suggests that it is turned off by default right now; I >>> have not checked it myself, but is that the case? >> >> No, it is not. Currently it is turned on, _but_ undocumented. > > Then it would be nice to make it documented and keep the default > perhaps?
Keep the default is easy (although I thought that we can turn off expensive pickaxe because it was undocumented and I suppose not many people used that). Should I send corrected patch (i.e. making pickaxe search a feature, but default on and perhaps overridable), or should I send correcting patch (i.e. make pickaxe search turned on by default patch)?
Documenting gitweb search operators (author:, committer:, pickaxe:) is not: where to put the documentation?
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git