Re: [PATCH 8/8] gitweb: Remove --parents from call to git-rev-list in parse_rev_list

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 6, 2006, 21:53 UTC
Message-ID: <edng0d$jng$1@sea.gmane.org>
In-Reply-To: <11575761821830-git-send-email-jnareb@gmail.com>

Jakub Narebski wrote:

Show 5 quoted lines

> Benchmarks (7 means patch before, 8 means this patch):
> # 1:gitweb/new~n 2:%e 3:%U 4:%s 5:ab-n10_cgi_time[ms] 6:[+/-sd] 7:ab-n10_perl_time[ms] 8:[+/-sd]
> 7 2.59  1.53 0  2621.073  234.2  2742.230   96.6
> 8 2.89  1.80 0  3081.722  246.6  3306.196  367.2
> 8 2.95  1.81 0  2952.253  155.9  3175.441  128.0

Corrected benchmark (on the same state of repository) are

7 2.67 1.60 0 2694.654 275.2 2866.028 168.4 8 2.84 1.86 0 2892.864 263.0 3135.065 68.1

where the benchmarking commands are
$ /usr/bin/time -f "%e %U %s" \
  GATEWAY_INTERFACE="CGI/1.1" HTTP_ACCEPT="*/*" REQUEST_METHOD="GET" \
  QUERY_STRING="p=git.git;a=history;f=gitweb/gitweb.perl" \
  GITWEB_CONFIG="~/git/gitweb/gitweb_config.perl \
  perl -- ~/git/gitweb/gitweb.perl
$ ab -n 10 "http://localhost/cgi-bin/gitweb/gitweb.cgi?p=git.git;a=history;f=gitweb/gitweb.perl"
$ ab -n 10 "http://localhost/perl/gitweb/gitweb.cgi?p=git.git;a=history;f=gitweb/gitweb.perl"

and we get version 7 using $ git checkout HEAD^ -- gitweb/gitweb.perl and updating gitweb.cgi in correct place.

So actually removing '--parents' option did make gitweb _slower_ (sic!), if only slightly.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git