Re: [PATCH] gitweb: optionally read config from GITWEB_CONFIG

From: Jakub Narebski <jnareb@gmail.com>
Date: Aug 2, 2006, 20:21 UTC
Message-ID: <ear1fp$j9p$2@sea.gmane.org>
In-Reply-To: <20060802192333.GA30861@coredump.intra.peff.net>

Jeff King wrote:

Show 6 quoted lines

> Configuration will first be taken from variables inside the gitweb.cgi
> script, which in turn come from the Makefile. Afterwards, the contents of
> GITWEB_CONFIG are read, overriding the builtin defaults.
> 
> This should eliminate the need for editing the gitweb script at all. Users
> should edit the Makefile and/or add a config file.

Very nice.

Show 9 quoted lines

> @@ -56,7 +50,7 @@ # URI of GIT logo
>  our $logo = "@@GITWEB_LOGO@@";
>  
>  # source of projects list
> -our $projects_list = "@@GITWEB_LIST@@" || "$projectroot";
> +our $projects_list = "@@GITWEB_LIST@@";
>  
>  # default blob_plain mimetype and default charset for text/plain blob
>  our $default_blob_plain_mimetype = 'text/plain';

But why that change?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git