Re: [PATCH] gitweb: optionally read config from GITWEB_CONFIG
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 2, 2006, 20:28 UTC
- Message-ID
- <7vu04uubl7.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060802192333.GA30861@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 17 quoted lines
> Configuration will first be taken from variables inside the gitweb.cgi > script, which in turn come from the Makefile. Afterwards, the contents of > GITWEB_CONFIG are read, overriding the builtin defaults. > > This should eliminate the need for editing the gitweb script at all. Users > should edit the Makefile and/or add a config file. > > Signed-off-by: Jeff King <peff@peff.net> > --- > This is on top of next. > > This patch seemed to get a favorable response, so I cleaned it up and > actually tested it. The main changes are reordering a few of the setup > statements so that changes introduced in the config file are respected > as suggested by Matthias (and a few by me). It would be good if other > gitweb people could check it over and/or try it with their config to > make sure I didn't miss anything.
Looks good -- thanks. Further comments from the list are very much appreciated.