Re: [PATCH] gitweb: optionally read config from GITWEB_CONFIG

From: Matthias Lederhofer <matled@gmx.net>
Date: Aug 2, 2006, 20:31 UTC
Message-ID: <E1G8NNl-0006ez-6J@moooo.ath.cx>
In-Reply-To: <ear1fp$j9p$2@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> wrote:

Show 12 quoted lines

> Jeff King wrote:
> > @@ -56,7 +50,7 @@ # URI of GIT logo
> >  our $logo = "@@GITWEB_LOGO@@";
> >  
> >  # source of projects list
> > -our $projects_list = "@@GITWEB_LIST@@" || "$projectroot";
> > +our $projects_list = "@@GITWEB_LIST@@";
> >  
> >  # default blob_plain mimetype and default charset for text/plain blob
> >  our $default_blob_plain_mimetype = 'text/plain';
> 
> But why that change?

Earlier this was undef if the user did not change it. Now this is always a string so the second one will probably never come into play except the user chooses to set the string to undef again.