Re: [PATCH] gitweb: optionally read config from GITWEB_CONFIG

From: Jeff King <peff@peff.net>
Date: Aug 2, 2006, 20:41 UTC
Message-ID: <20060802204154.GA15678@sigio.intra.peff.net>
In-Reply-To: <ear1fp$j9p$2@sea.gmane.org>

On Wed, Aug 02, 2006 at 10:21:43PM +0200, Jakub Narebski wrote:

Show 11 quoted lines

> > @@ -56,7 +50,7 @@ # URI of GIT logo
> >  our $logo = "@@GITWEB_LOGO@@";
> >  
> >  # source of projects list
> > -our $projects_list = "@@GITWEB_LIST@@" || "$projectroot";
> > +our $projects_list = "@@GITWEB_LIST@@";
> >  
> >  # default blob_plain mimetype and default charset for text/plain blob
> >  our $default_blob_plain_mimetype = 'text/plain';
> 
> But why that change?

Because the previous order was:
  1. set projectroot to build-time default
  2. set projects_list to build-time default or $projectroot
  3. read variables, including $projectroot, from config file
If you kept $projects_list empty but set $projectroot in your config,
the value of projects_list would be the build-time $projectroot, not the
config-time. If you look further in the patch, you will see that we set
up projects_list later.

-Peff