git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: use single quotes for values replaced by the Makefile

From
MLMatthias Lederhofer <matled@gmx.net>
Date
Aug 2, 2006, 20:57 UTC
Message-ID
<E1G8Nm7-0007bC-7d@moooo.ath.cx>
In-Reply-To
<7vmzamuaj6.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
Show 6 quoted lines
> I understand that (1) "@@FOO@@" is problematic, (2) being able
> to run gitweb/gitweb.perl while coming up with improvements is
> nice, but (3) not being able to say "/etc/foo/$ENV{SITE_NAME}"
> is quite a drawback on the deployment side.
> 
> So why don't we use something other than @@, perhaps "++FOO++"?

That's the other way to solve this. If there is no typical character for filenames which is handled different in double quotes this is fine for me too.

> I'm inclined to take these two patches:
> 
>     gitweb: optionally read config from GITWEB_CONFIG (Jeff King)
>     gitweb: require $ENV{'GITWEB_CONFIG'} (Matthias Lederhofer)

The suggestion by Jeff King to use our $GITWEB_CONFIG = $ENV{GITWEB_CONFIG} || '@@GITWEB_CONFIG@@'; sounds reasonable too.

> so on top of them something like this?
[patch replacing @@ with ++]
Ack.
Previous: Junio C HamanoNext: Jeff King
Message 4 of 16 in “gitweb: optionally read config from GITWEB_CONFIG”
  1. gitweb: optionally read config from GITWEB_CONFIGJeff King, Aug 2, 2006
  2. gitweb: use single quotes for values replaced by the MakefileMatthias Lederhofer, Aug 2, 2006
  3. Junio C HamanoAug 2, 2006
  4. Matthias LederhoferAug 2, 2006
  5. Jeff KingAug 2, 2006
  6. Jakub NarebskiAug 2, 2006
  7. Matthias LederhoferAug 2, 2006
  8. Jakub NarebskiAug 2, 2006
  9. Jeff KingAug 2, 2006
  10. Junio C HamanoAug 2, 2006
  11. gitweb: require $ENV{'GITWEB_CONFIG'}Matthias Lederhofer, Aug 2, 2006
  12. Jeff KingAug 2, 2006
  13. Junio C HamanoAug 2, 2006
  14. Jeff KingAug 2, 2006
  15. Luben TuikovAug 2, 2006
  16. Jeff KingAug 2, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.