git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: don't cc *-by lines with '-' prefix

From
Joe Perches <joe@perches.com>
Date
Mar 18, 2019, 07:02 UTC
Message-ID
<e2c7cc07618ecc753fe5939a90b562c97885af39.camel@perches.com>
In-Reply-To
<xmqqh8c03dcz.fsf@gitster-ct.c.googlers.com>
On Mon, 2019-03-18 at 15:28 +0900, Junio C Hamano wrote:
Show 8 quoted lines
> Joe Perches <joe@perches.com> writes:
> 
> > My preference would be for correctness.
> > I presume something like this isn't too onerous.
> 
> I am guessing that /^---/ is to stop at the three-dash line *OR*
> after the initial handful of lines of the first diff header (as the
> last resort) and that is why it is not looking for /^---$/.
Right.
Show 9 quoted lines
> If that is the case, I think it makes a lot of sense.  It is a
> general improvement not tied to the case that triggered this thread.
> 
> Independently, I think it makes sense to do something like
> 
> 	/^([a-z][a-z-]*-by|Cc): (.*)/i
> 
> to tighten the match to exclude a non-trailer; that would have been
> sufficient for the original case that triggered this thread.
Previous: Junio C HamanoNext: Baruch Siach
Message 10 of 18 in “send-email: don't cc *-by lines with '-' prefix”
  1. send-email: don't cc *-by lines with '-' prefixBaruch Siach, Mar 16, 2019
  2. Joe PerchesMar 16, 2019
  3. Baruch SiachMar 16, 2019
  4. Joe PerchesMar 16, 2019
  5. Baruch SiachMar 16, 2019
  6. Joe PerchesMar 16, 2019
  7. Rasmus VillemoesMar 17, 2019
  8. Joe PerchesMar 18, 2019
  9. Junio C HamanoMar 18, 2019
  10. Joe PerchesMar 18, 2019
  11. Baruch SiachApr 4, 2019
  12. Junio C HamanoApr 4, 2019
  13. Baruch SiachApr 4, 2019
  14. Junio C HamanoApr 4, 2019
  15. Rasmus VillemoesApr 4, 2019
  16. Junio C HamanoApr 4, 2019
  17. Jeff KingApr 4, 2019
  18. Junio C HamanoApr 4, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.