Re: [PATCH] send-email: don't cc *-by lines with '-' prefix

From: Baruch Siach <baruch@tkos.co.il>
Date: Apr 4, 2019, 09:27 UTC
Message-ID: <87zhp6jf2o.fsf@tarshish>
In-Reply-To: <xmqqk1gaf7oe.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, Apr 04 2019, Junio C. Hamano wrote:

Show 17 quoted lines

> Baruch Siach <baruch@tkos.co.il> writes:
>
>>> Independently, I think it makes sense to do something like
>>>
>>> 	/^([a-z][a-z-]*-by|Cc): (.*)/i
>>>
>>> to tighten the match to exclude a non-trailer; that would have been
>>> sufficient for the original case that triggered this thread.
>>
>> Is there anything I need to do more to get this fix applied for the next
>> git release?
>
> Get "this" fix applied?  I think we should tighten the regexp to
> exclude a non-trailer, which would have been sufficient for the
> original case without anything else in "this" fix.  So in short, I
> do not think "this" fix won't be applied without further tweaking
> ;-)

This is exactly what "this" patch (referenced in the title of "this" thread) is doing:

  https://public-inbox.org/git/eec56beab016182fb78fbd367fcfa97f2ca6a5ff.1552764410.git.baruch@tkos.co.il/

Am I missing something?

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -