Re: [PATCH] send-email: don't cc *-by lines with '-' prefix

From: Joe Perches <joe@perches.com>
Date: Mar 16, 2019, 20:23 UTC
Message-ID: <2220d599992885eca1709f316a3e862c671301ff.camel@perches.com>
In-Reply-To: <87y35eziel.fsf@tarshish>

On Sat, 2019-03-16 at 22:14 +0200, Baruch Siach wrote:

> Hi Joe,

Hello Baruch.

Show 22 quoted lines

> On Sat, Mar 16 2019, Joe Perches wrote:
> > So buildroot uses '+Signed-off-by:' and '-Signed-off-by:' lines
> > for some internal purpose?
> > 
> > Why?
> > 
> > https://buildroot.org/downloads/manual/manual.html
> > 
> > doesn't mention it.
> 
> No. Patches to the Buildroot project often add or remove patch
> files. See this one for example:
> 
>   http://lists.busybox.net/pipermail/buildroot/2019-March/244762.html
> 
> In this case 'git send-email' added Peter Korsgaard to cc because a
> patch file with his sign-off is removed.
> 
> (mbox) Adding cc: Baruch Siach <baruch@tkos.co.il> from line 'From: Baruch Siach <baruch@tkos.co.il>'
> (body) Adding cc: Petr Vorel <petr.vorel@gmail.com> from line 'Cc: Petr Vorel <petr.vorel@gmail.com>'
> (body) Adding cc: Baruch Siach <baruch@tkos.co.il> from line 'Signed-off-by: Baruch Siach <baruch@tkos.co.il>'
> (body) Adding cc: Peter Korsgaard <peter@korsgaard.com> from line '-Signed-off-by: Peter Korsgaard <peter@korsgaard.com>'

I see.

IMO git send-email should not really be adding -by: lines from actual patch content but only from lines before any '^---'.