Re: [PATCH] send-email: don't cc *-by lines with '-' prefix

From: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Date: Apr 4, 2019, 09:42 UTC
Message-ID: <dd8160f8-0e5e-1024-53c1-1a9f23423af5@rasmusvillemoes.dk>
In-Reply-To: <87zhp6jf2o.fsf@tarshish>

On 04/04/2019 11.27, Baruch Siach wrote:

Show 27 quoted lines

> Hi Junio,
> 
> On Thu, Apr 04 2019, Junio C. Hamano wrote:
>> Baruch Siach <baruch@tkos.co.il> writes:
>>
>>>> Independently, I think it makes sense to do something like
>>>>
>>>> 	/^([a-z][a-z-]*-by|Cc): (.*)/i
>>>>
>>>> to tighten the match to exclude a non-trailer; that would have been
>>>> sufficient for the original case that triggered this thread.
>>>
>>> Is there anything I need to do more to get this fix applied for the next
>>> git release?
>>
>> Get "this" fix applied?  I think we should tighten the regexp to
>> exclude a non-trailer, which would have been sufficient for the
>> original case without anything else in "this" fix.  So in short, I
>> do not think "this" fix won't be applied without further tweaking
>> ;-)
> 
> This is exactly what "this" patch (referenced in the title of "this"
> thread) is doing:
> 
>   https://public-inbox.org/git/eec56beab016182fb78fbd367fcfa97f2ca6a5ff.1552764410.git.baruch@tkos.co.il/
> 
> Am I missing something?

My ack for Baruch's original patch, which AFAICT is identical with Junio's suggestion, still stands. FWIW, I'm against Joe's suggestion of stopping at a line matching /^---/, since it's not unlikely somebody does something like

---- dmesg output ---- bla bla ----

in the commit message.

Since all lines (except for some of the diff header lines) in the patch part begin with space, - or +, insisting on a the line starting with a letter should be sufficient for excluding any random Foo-by lines that may appear in the patch part.

Rasmus